Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0.6 3/3/2016 #449

Closed
wants to merge 2 commits into from
Closed

v3.0.6 3/3/2016 #449

wants to merge 2 commits into from

Conversation

robkspeer
Copy link
Contributor

Version 3.0.6 - March 3, 2016

No breaking changes

Bug Fixes

robkspeer added 2 commits March 3, 2016 13:26
@robkspeer
v3.0.6 3/3/2016
2b4f4c5 
## Version 3.0.6 - March 3, 2016

No break changes

**Bug Fixes**

* Closes Esri#448 - OfflineEditAdvanced - after multiple offline restarts,
UID begins at -1 again for Adds.
@robkspeer
Update CHANGELOG.md
be4a9ad
@robkspeer robkspeer mentioned this pull request Mar 3, 2016
Closed
@robkspeer robkspeer closed this Mar 3, 2016
@andygup
Copy link
Member

andygup commented Mar 3, 2016

Did you get the preserveComments figured out? My guess was it might be a grunt-contrib-uglify version issue. I'm running 0.9.2 locally (npm list grunt-contrib-uglify)

Lemme know when it's stable, and I'll take a look at the core changes?

@robkspeer robkspeer deleted the robkspeerBranch branch March 3, 2016 21:31
@robkspeer
Copy link
Contributor Author

npm installed grunt-contrib-uglify v0.11.1 for me, altho the uglify docs still show that 'some' should have gotten rid of the // and /* */ comments?? I don't know what was up.. I also haven't used that option before so I can't really say.

PR #450 does have the core changes in place for lib/edit/editsStore.js, lib/edit/OfflineEditAdvanced.js, and lib/edit/OfflineEditBasic.js if you want to check those out. The build was good otherwise except for that comment issue I believe.

@andygup
Copy link
Member

andygup commented Mar 3, 2016

Nice job, btw!

Yep, there have been grumblings that the latest versions have breaking changes to the way comments used to work, and that the changes weren't well documented. I'll bump up my uglify version and take a look.

I'll also take a look at core tomorrow.

@andygup
Copy link
Member

andygup commented Mar 3, 2016

RE: uglify and comments not working correctly gruntjs/grunt-contrib-uglify#366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robkspeer @andygup